-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging release/1.7 into main #14482
Conversation
How is this related to #14474? |
Fix #14338 --------- Co-authored-by: yaricrolletservico <101557629+yaricrolletservico@users.noreply.github.com> Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
I don't know if we should do this from GH, I will try to merge it and do manual things if necessary. |
Sounds good. If you end up no using this Branch, you can close it. |
4e6cd2f
to
a6b807d
Compare
That doesn't work as expected. Closing it and doing it manually |
It's release/1.7, so no I won't close it ;) |
main is now up to date. We need a new PR that contains the version updates, and "this one" should be called Release 1.7.1, not the other ones that were called "Release 1.7.1" which actually contained bug fixes. |
@sebastienros I am not following you. Why do we need another PR? When we released v1.7.0, we created a branch called Now you merged |
We need to change release/1.7 content with a release notes, update the 1.7.0 versions to 1.7.1.
The fixes, yes, not the docs, versions and release notes What we did in this PR: #14111 |
Then we create the tag v1.7.1 from this release/1.7 branch |
We are on the same page now! We'll get a PR going soon |
No description provided.