Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyed services #14789

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Keyed services #14789

merged 11 commits into from
Dec 1, 2023

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Nov 29, 2023

Working branch to understand how it works.

Quickly done so may need to be tweaked.

Can't right now, need to leave maybe this night.

@jtkech jtkech requested a review from kevinchalet as a code owner November 29, 2023 11:42
@jtkech jtkech changed the title Start on keyed services Keyed services Nov 30, 2023
MikeAlhayek
MikeAlhayek approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtkech I tested out these changes and indeed they solve the issue. Thank you

@MikeAlhayek MikeAlhayek mentioned this pull request Nov 30, 2023
Closed
@jtkech
Copy link
Member Author

jtkech commented Nov 30, 2023

Okay good to know

@hishamco
Copy link
Member

I need to tested too against my Azure Email PR, if all goes well we need to merge it ASAP

@hishamco hishamco mentioned this pull request Nov 30, 2023
Closed
@MikeAlhayek MikeAlhayek mentioned this pull request Nov 30, 2023
Closed
@MikeAlhayek
Copy link
Member

@hishamco did you test this out? If so, please approve it so we can merge it

@hishamco
Copy link
Member

hishamco commented Dec 1, 2023

Unfortunately, I was busy with some PRs, I hope test this today alongside with Azure Email pr

hishamco
hishamco requested changes Dec 1, 2023
View reviewed changes
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Outdated Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Outdated Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Outdated Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Show resolved Hide resolved
...rchardCore/OrchardCore.Abstractions/Shell/Builders/Extensions/ServiceDescriptorExtensions.cs Show resolved Hide resolved
src/OrchardCore/OrchardCore/Shell/Builders/Extensions/ServiceCollectionExtensions.cs Show resolved Hide resolved
@hishamco hishamco removed the request for review from sfmskywalker December 1, 2023 21:16
@hishamco hishamco force-pushed the jtkech/keyed-services branch from 80b385a to f82c361 Compare December 1, 2023 21:19
@hishamco hishamco merged commit f8a587e into main Dec 1, 2023
3 checks passed
@hishamco hishamco deleted the jtkech/keyed-services branch December 1, 2023 22:23
@jtkech
Copy link
Member Author

jtkech commented Dec 2, 2023

@hishamco Thanks for merging

But generally it's not legitimate to add yourself you as a co-author on a given PR, moreover for useless or wrong changes, assumed as such at one point as everybody can make mistakes ;)

@hishamco
Copy link
Member

hishamco commented Dec 2, 2023

Sorry JT, the git shows the co-author because I added two commits for using expression bodies and some formats

Frankly I didn't mean it to be co-author all the PR credits for you ;)

urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@jtkech @hishamco @urbanit
Keyed services (OrchardCMS#14789)
1a422f6 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek approved these changes

@hishamco hishamco hishamco approved these changes

@kevinchalet kevinchalet Awaiting requested review from kevinchalet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtkech @hishamco @MikeAlhayek