Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .form-label to the labels for proper rendering #14806

Merged
merged 7 commits into from
Dec 3, 2023
Merged

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Dec 2, 2023

One of the breaking changes in bootstrap which was not addressed during bootstrap 5 migration.

Breaking Form labels now require .form-label.

https://getbootstrap.com/docs/5.3/migration/#forms

@MikeAlhayek MikeAlhayek requested a review from agriffard December 2, 2023 01:19
@MikeAlhayek
Copy link
Member Author

I am half way done. I'll remove the donotmerge label when ready

@MikeAlhayek
Copy link
Member Author

@agriffard are you able to checkout this PR if you have time?

Copy link
Member

@agriffard agriffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants