Missing SmtpSettings Options Setup #14920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
approved these changes
Dec 19, 2023
|
You're right JT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmtpSettingsConfiguration : IConfigureOptions<SmtpSettings>getsSmtpSettingsfrom Site Settings to setup anSmtpSettingsas options allowing to inject these settings throughIOptions<SmtpSettings>.But some fields (I assume new fields) are not setup, so when injecting
IOptions<SmtpSettings>as it is done inSmtpServicethese fields are not retrieved (unless if set by another tenant configuration).@hishamco For example, how can we expect that
SmtpServiceretrieveIgnoreInvalidSslCertificatethroughIOptions<SmtpSettings>if it is not set inSmtpSettingsConfiguration.