Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.8 #14939

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Release 1.8 #14939

merged 9 commits into from
Jan 2, 2024

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Dec 22, 2023

Fix #14940

@MikeAlhayek
Copy link
Member Author

@agriffard can you please release the translation package?

@agriffard
Copy link
Member

@agriffard can you please release the translation package?

.po files updated and PR is merged, you can make a release for https://github.com/OrchardCMS/OrchardCore.Translations/

@MikeAlhayek
Copy link
Member Author

@agriffard thanks for updating the po files. I release the translations and updated this PR.

@sebastienros anything else needs to be done here or can we release it? If you see now issues, I can release 1.8 tomorrow.

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Dec 23, 2023

@sebastienros these are the next steps just to make sure we are on the same page before I push the release.

  1. Merge this PR. This will release 1.8.0 on cloud smith (I don't think it matters. But we could disable the preview action momentarily to save time.)
  2. Merge main back into release/1.8 using squash.
  3. Update main by setting <VersionSuffix>preview</VersionSuffix> and <VersionPrefix>1.9.0</VersionPrefix> so any new commits into main release a preview version on cloud smith using 1.9.0-preview.
  4. Release 1.8 using the release/1.8 branch.

Let me know if I missed anything

@sebastienros
Copy link
Member

Ok to squash-merge to main, no need to merge back then since it's the same things at this point. When it's done click the "undo" button to restore the release/1.8 branch as it will be deleted automatically because it's a PR.

Then one commit on main to revert the "preview" and set the new version. You can then create the release out of release/1.8 and create the tag v1.8.0 by doing so.

@MikeAlhayek MikeAlhayek merged commit b8d6d96 into main Jan 2, 2024
3 checks passed
@MikeAlhayek MikeAlhayek deleted the release/1.8 branch January 2, 2024 21:00
@MikeAlhayek MikeAlhayek restored the release/1.8 branch January 2, 2024 21:00
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.8
3 participants