-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved MediaField Graphql support #15003
Merged
Merged
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c3c2d82
Add media filenames on MediaFieldType
hyzx86 7fdfddd
add MediaFileItemType
hyzx86 78f1585
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
hyzx86 b3c1484
fix code style
hyzx86 e2402c8
Merge branch 'mediaFileNames' of https://github.com/hyzx86/OrchardCor…
hyzx86 778a472
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
hyzx86 4381d1a
Merge branch 'main' into mediaFileNames
hishamco 1190a6f
merge main
hyzx86 f24484d
fix new graphql API
hyzx86 7ae8e52
merge main
hyzx86 eb41064
Merge branch 'main' into mediaFileNames
hyzx86 efcdb83
Merge branch 'main' into mediaFileNames
hyzx86 7b5c76d
Merge branch 'main' into mediaFileNames
hyzx86 e7d7e34
Merge branch 'main' into mediaFileNames
hyzx86 8c9c2b6
add MediaText
f14109a
remove empty line
f069176
Merge branch 'main' into mediaFileNames
hyzx86 4df8497
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
MikeAlhayek 528c6d8
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
MikeAlhayek 868c1f7
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
MikeAlhayek a01632b
Update MediaFieldQueryObjectType.cs
hyzx86 912616c
Update src/OrchardCore.Modules/OrchardCore.Media/GraphQL/MediaFieldQu…
hyzx86 4f11c4f
Merge branch 'main' into mediaFileNames
hyzx86 de11ba8
Handle invalid recipe files from breaking the harvester (#16490)
MikeAlhayek 9df8f05
Add RemovePart<TPart> extension (#16491)
MikeAlhayek 8366a89
Move Media Permissions to Media.Core (#16493)
MikeAlhayek 3c99705
Fix that you can't add a content part when it's already added as a Na…
lampersky 6ea02df
Add CanHandleModelAsync (#16501)
MikeAlhayek e18beee
Merge branch 'mediaFileNames' of https://github.com/hyzx86/OrchardCor…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this now redundant and can be deprecated? (But kept for now for backward compatibility.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that. It would be great if we can remove the old redundant fields. It's a breaking change, but we already have lot's of them, so why not take this as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it's a good time to remove them in 2.0.
@Skrypt what do you think? Or remove them in a new PR?