Fix TheAdminTheme layout margin and padding #15143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please screenshot before & after |
|
There isn't visual difference. Just better layout since this uses padding not margin. So the scroll bar shows only when the screen in full. Also, instead of using 15px padding, we use 1rem just like bootstrap for consistency. Feel free to checkout the PR. |
hishamco
approved these changes
Jan 21, 2024
|
@MikeAlhayek I just noticed UI issue
|
|
What is the issue? |
|
Look to the button underneath, seems the padding or margin almost 0 |
Skrypt
pushed a commit
that referenced
this pull request
Jan 25, 2024
Skrypt
pushed a commit
that referenced
this pull request
Jan 25, 2024
^ This is the 1st commit message: Add GetCulture() extension method ^ This is the commit message #2: Cleanup ISmsService (#15142) ^ This is the commit message #3: Fix TheAdminTheme layout margin and padding (#15143) ^ This is the commit message #4: Fix SectionDisplayDriver prefix (#15123) ^ This is the commit message #5: Prefill template name when creating a template. (#15145) ^ This is the commit message #6: Set the User Localization feature priority ^ This is the commit message #7: Fix issue with default culture not selected When currentUserCulture is null or supportedCulture doesn't contain currentUserCulture. ^ This is the commit message #8: Update the height of the admin content (#15153) ^ This is the commit message #9: Eliminate the anti-discovery pattern in Elasticsearch (#15134) ^ This is the commit message #10: Renaming and cleaning up search services (#15156) ^ This is the commit message #11: mkdocs-material 9.5.5
Skrypt
added a commit
that referenced
this pull request
Jan 25, 2024
…themes (#11243) Cleanup ISmsService (#15142) Fix TheAdminTheme layout margin and padding (#15143) Fix SectionDisplayDriver prefix (#15123) Prefill template name when creating a template. (#15145) Set the User Localization feature priority Fix issue with default culture not selected When currentUserCulture is null or supportedCulture doesn't contain currentUserCulture. Update the height of the admin content (#15153) Eliminate the anti-discovery pattern in Elasticsearch (#15134) Renaming and cleaning up search services (#15156) mkdocs-material 9.5.5 User Timezone settings refresh Originally from Hisham revert manifest
hishamco
pushed a commit
that referenced
this pull request
Feb 1, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.