fix(AuditTrail): allow to see action option only if user have view au… #15432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit trail permission
hishamco
requested changes
Mar 1, 2024
src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentsDriver.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentsDriver.cs
Outdated
Show resolved
Hide resolved
…s/AuditTrailContentsDriver.cs Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
…s/AuditTrailContentsDriver.cs Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
|
I won't be able to work on reviewing this. |
|
@Piedone I remember on of the Lombiq team who implement AuditTrail, is it Gabor? |
Piedone
requested changes
Mar 1, 2024
src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentsDriver.cs
Outdated
Show resolved
Hide resolved
hishamco
reviewed
Mar 1, 2024
src/OrchardCore.Modules/OrchardCore.Contents/AuditTrail/Drivers/AuditTrailContentsDriver.cs
Outdated
Show resolved
Hide resolved
Piedone
approved these changes
Mar 1, 2024
|
@all-contributors please add @PiemP for code. |
|
Ah, just the name is "tempcode" there. |
|
Thank you for your repeated contribution! |
|
Ya, @PiemP is already a contributor AFAIK, but it's good that the bot is confirm that ;) |
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
…rchardCMS#15432) Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15431
fix(AuditTrail): allow to see action option only if user have view audit trail permission