Add a way to hide ContentTypeDefinitionSettings

[MikeAlhayek]

No description provided.

[hishamco]

What are the reasons for hiding the ContentTypeDefinitionSettings?

[MikeAlhayek]

In certain cases like when creating CustomSettings or CustomUserSettings, these options are useless. So it would be nice to hide them instead since they do nothing.

[hishamco]

I remembered the related issue, could you please share a GIF screenshot to show how it works in the UI

[hyzx86]

relate :#13335

[Piedone]

The "Full-text" section is something like this too. How about hiding that as well?

[Piedone]

See #15472 (review).

[hyzx86]

Note that in the permissions module is recommended to be retained, because I have used the ContentType permissions to distinguish which users can view or modify the specified CustomSettings

[Piedone]

Good point. Perhaps hiding the other options is not as obviously generally beneficial as we thought either.

[MikeAlhayek]

Good point. Maybe we should only show "Securable" option only and hide the rest of the options since they are related to the content UI

[hyzx86]

Similarly with CustomUserSettings,
I use the dynamic permissions to determine if the user can modify these extended properties on their own
It's just that these functions are in my react client, and I open up some web api from OC.
So if someone has deleted the dynamic permissions... I will lost my function 😂

[MikeAlhayek]

Well you can still change the settings via code (migration). But, not the UI. So yes it is not a good idea to remove securable option from the UI. I'll change the setting to show Securable and hide the rest

[MikeAlhayek]

@Piedone @hyzx86 I kept the securable options in custom site/user settings.

[Piedone]

That looks good, but I'm still awaiting your answer on #15472 (review) :)

[MikeAlhayek]

That looks good, but I'm still awaiting your answer on #15472 (review) :)

Sorry I missed your comment couple of times. Full-Text settings are part of a different driver FullTextAspectSettingsDisplayDriver. I would say, that that out of this PR if we need to hide that too. But, not sure we should hide it. Is it possible that someone want to allow search in the custom user settings or site settings? Probably now, but not sure.

[Piedone]

I'd guess that people wanting to search Custom Settings has a lower chance than them wanting to list them.

[MikeAlhayek]

I am not against hiding the search settings. But I just don't want to do it in this PR. The intention behind this PR was just to add configuration to show/hide the listable, creatable, draftable, flags. We can create another PR around the search settings and other settings like Elasticsearch, Lucene,Azure AI.

[Piedone]

OK then!