Issue 15492 bugfix: Prevent session connection closing in WorkflowTypeController #15495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs
Show resolved
Hide resolved
sebastienros
approved these changes
Mar 12, 2024
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15492
The reason for the error is that in version OrchardCore 1.8.2 WorkflowTypeController was added using (and thereby disposing) when calling CreateConnectionAsync method of Session object. A session object is an object created probably with a scoped lifetime and will be destroyed with a destructor call and mandatory closure with a connection in the finally block at the end of the web request, i.e. there is no need to use using during web request processing when Session calls can still be made.