Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand Twitter to X #15528

Merged
merged 9 commits into from
Apr 13, 2024
Merged

Brand Twitter to X #15528

merged 9 commits into from
Apr 13, 2024

Conversation

hishamco
Copy link
Member

This does not include module or APIs rename to avoid breaking changes

@hishamco hishamco requested a review from agriffard as a code owner March 17, 2024 00:11
@MikeAlhayek
Copy link
Member

Did this request come from Elon directly? Because he is the only one that seems to care about the new name lol.

Please update the appsettings.json file to change OrchardCore_Twitter to OrchardCore_X. Maybe support both keys of the configuration to avoid a breaking change. But only document OrchardCore_X.

Also, document the change in the release notes.

@hishamco hishamco requested a review from MikeAlhayek April 12, 2024 23:02
@MikeAlhayek MikeAlhayek merged commit fe901a1 into main Apr 13, 2024
5 checks passed
@MikeAlhayek MikeAlhayek deleted the hishamco/twitter branch April 13, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants