Update JOptions configuration (Lombiq Technologies: OCORE-149)

[sarahelsaig]

Fixes #15533

[MikeAlhayek]

This fix is good and will result in one less breaking change. I am not sure if there is a negative impact from this change. @sebastienros any thoughts if there is a downside from taking this change?

[MikeAlhayek]

@sarahelsaig on a second note, I think this change should not be part of Base (maybe we do, but probably not). It should only be part of the ContentSerializerOptions

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.Abstractions/Extensions/ContentSerializerJsonOptionsConfiguration.cs

Not that ContentSerializerOptions is the only options that impact serializing and deserializing object in YesSql.

[sarahelsaig]

@sarahelsaig on a second note, I think this change should not be part of Base (maybe we do, but probably not). It should only be part of the ContentSerializerOptions

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.Abstractions/Extensions/ContentSerializerJsonOptionsConfiguration.cs

Not that ContentSerializerOptions is the only options that impact serializing and deserializing object in YesSql.

Won't it be bad if Base has a different ReferenceHandler than ContentSerializerOptions?

[MikeAlhayek]

Won't it be bad if Base has a different ReferenceHandler than ContentSerializerOptions?

I don't think so. YesSQL can has different options. for example, in the YesSQL we add converters for different types.

[sarahelsaig]

@MikeAlhayek I've made the change you suggested and unfortunately it won't work. I don't think the problem is only related to YesSQL.

I guess your approach works as long as the original structure (i.e. the ContentElement.Elements) is maintained, but it breaks if you use methods which clear that element list such as ContentElement.Apply(), ContentElement.Apply<TPart>() or ContentItem.Merge(). At that point trying to access a child item (e.g. using the ContentItem.As<TPart>()) causes a de-serialization which now only uses the JOptions.Default. This is too fragile, I'm not sure if anything besides read-only access is safe.

So I think this config won't be usable unless we put it into JOptions.Base after all.