Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid NRE in ElasticQueryService.SearchAsync() #15600

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Avoid NRE in ElasticQueryService.SearchAsync() #15600

merged 1 commit into from
Mar 27, 2024

Conversation

hishamco
Copy link
Member

No description provided.

@hishamco hishamco requested a review from Skrypt March 27, 2024 03:00
@Skrypt
Copy link
Contributor

Skrypt commented Mar 27, 2024 •
edited
Loading

Can you explain what you are trying to do here @hishamco ?
Just by reading these changes quickly doesn't seem appropriate to me.

@Skrypt
Copy link
Contributor

Skrypt commented Mar 27, 2024

@hishamco My mistake, I thought I was looking at the .cshtml file. It should be all good.

@Skrypt Skrypt merged commit b829e2a into main Mar 27, 2024
5 checks passed
@Skrypt Skrypt deleted the hishamco/elastic-search branch March 27, 2024 13:33
@hishamco
Copy link
Member Author

What about the comment #15600 (comment)?

@Skrypt
Copy link
Contributor

Skrypt commented Mar 27, 2024

I would need to try it and see what happens when you start OC with a bad Elasticsearch config for example. You need to have the Search feature enabled and try to make a search with a term. You can also try to go in the admin UI I guess.

This was referenced Apr 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skrypt Skrypt Skrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamco @Skrypt