Adjust content type condition to evaluate to true when no content is displayed #15603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…displayed and the operation for the given condition is a negation.
…ssuming all implementations of INegateOperation should return true when no content types are considered.
|
This is a follow-up from #15602. And now there's no policy bot... Anyway, you accepted the CLA. |
Piedone
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
This seems quite clear-cut to me, but I'm not sure if I'm missing something obvious. @deanmarcussen could you please also take a quick look?
MikeAlhayek
requested changes
Mar 28, 2024
src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionEvaluatorDriver.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
changed the title
rwawr
commented
Mar 28, 2024
src/OrchardCore.Modules/OrchardCore.Rules/Drivers/ContentTypeConditionEvaluatorDriver.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Alhayek <mike@crestapps.com>
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust content type condition to evaluate to true when no content is displayed and the operation for the given condition is a negation to address. Fixes #15452.