Add HTML support to notification summary #15607
Conversation
|
Can we specify |
When you create notification, you can generate a link. For example, in the workflow, you can create a clickable notification by using something like this You can create any HTML you want. |
| updater.ModelState.AddModelError(Prefix, nameof(viewModel.HtmlBody), S["HTML Body field does not contain a valid Liquid expression. Details: {0}", string.Join(' ', htmlBodyErrors)]); | ||
| } | ||
|
|
||
| if (updater.ModelState.IsValid) |
There was a problem hiding this comment.
We should not do this at all in the UpdateAsync. Just update the model and send it back to the EditAsync with an UpdateEditorContext. You need to have the values updated to display on that form on validation error. Else, these user values are lost unless you use an asp-for on the input. Also, as long as the ModelState is not valid it should simply not persist the data in DB.
There was a problem hiding this comment.
@Skrypt This is done in an abstract class which call a virtual method UpdateActivityAsync only if the model is valid. We do similar logic in other base drivers like ActivityDisplayDriver
Why should we not do this?
There was a problem hiding this comment.
Going to sleep will try to explain tomorrow. See my display driver pr.
There was a problem hiding this comment.
I think I will just wait for next triage meeting and explain this. Or I should do a video that explains it all.
There was a problem hiding this comment.
Sounds good. I suggest opening an issue and explain it with video. Maybe a good topic for Tuesday as well. If this should not be done here, then we should change it in other places too since it is a behavior that we use in other places.
There was a problem hiding this comment.
I was hoping to follow up on this today on meeting but it will be more likely for next time..
Fix #15606