Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the removal of PopulateSettings in 1.9 release notes #15618

Merged
merged 1 commit into from
Mar 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/docs/releases/1.9.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,29 @@ services.AddJsonDerivedTypeInfo<UrlCondition, Condition>();

In particular, any type introduced in custom modules inheriting from `MenuItem`, `AdminNode`, `Condition`, `ConditionOperator`, `Query`, `SitemapType` will have to use this method.

- The extension `PopulateSettings<T>(model)` was removed from `PartFieldDefinition`. If you are using this method in your code, you'll have to get the settings using the `Settings` object directly. For instance, if you have this code,

```csharp
public override IDisplayResult Edit(ContentPartFieldDefinition partFieldDefinition)
{
return Initialize<NumericFieldSettings>("NumericFieldSettings_Edit", model => partFieldDefinition.PopulateSettings(model));
}
```

You'll change it to the following:

```csharp
public override IDisplayResult Edit(ContentPartFieldDefinition partFieldDefinition)
{
return Initialize<NumericFieldSettings>("NumericFieldSettings_Edit", model =>
{
var settings = partFieldDefinition.Settings.ToObject<NumericFieldSettings>();
model.Hint = settings.Hint;
// ...
});
}
```

### Media Indexing

Previously, `.pdf` files were automatically indexed in the search providers (Elasticsearch, Lucene or Azure AI Search). Now, if you want to continue to index `.PDF` file you'll need to enable the `OrchardCore.Media.Indexing.Pdf` feature.
Expand Down
Loading