Save byte array allocations #15630
Merged
Save byte array allocations #15630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Mar 30, 2024
| @@ -3,7 +3,7 @@ | |||
| @inject IContentManager ContentManager | |||
|
|
|||
| @{ | |||
| var matchAllQuery = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(@"SELECT * FROM ContentItemIndex")); | |||
| var matchAllQuery = OrchardCore.Queries.Sql.ViewModels.AdminQueryViewModel.MatchAllQueryBase64; | |||
There was a problem hiding this comment.
Suggested change
| var matchAllQuery = OrchardCore.Queries.Sql.ViewModels.AdminQueryViewModel.MatchAllQueryBase64; | |
| var matchAllQuery = Model.MatchAllQueryBase64; |
There was a problem hiding this comment.
It's not part of the usings
There was a problem hiding this comment.
Sorry, I mean to use the model, I updated the above suggestion
There was a problem hiding this comment.
Static properties can't be accessed from instance references.
| @@ -6,6 +6,8 @@ namespace OrchardCore.Queries.Sql.ViewModels | |||
| { | |||
| public class AdminQueryViewModel | |||
| { | |||
| public static string MatchAllQueryBase64 { get; } = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(@"SELECT * FROM ContentItemIndex")); | |||
There was a problem hiding this comment.
Suggested change
| public static string MatchAllQueryBase64 { get; } = Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(@"SELECT * FROM ContentItemIndex")); | |
| public static string MatchAllQueryBase64 => Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(@"SELECT * FROM ContentItemIndex")); |
There was a problem hiding this comment.
That would evaluate on each call. Which was done before this change.
MikeAlhayek
approved these changes
Mar 30, 2024
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.