Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensions to register conditions in the Rules module #15645

Merged
merged 12 commits into from
Apr 7, 2024
Merged

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Apr 2, 2024

Here is a summary of the changes:

  • Added new OrchardCore.Rules.Core project.
  • Added the new AddRule<> extensions in the Core project
  • Cleaned up the OrchardCore.Rules project by using the new extensions.

@MikeAlhayek MikeAlhayek requested a review from agriffard as a code owner April 2, 2024 20:05
@MikeAlhayek MikeAlhayek requested a review from sebastienros April 2, 2024 20:07
@hishamco
Copy link
Member

hishamco commented Apr 3, 2024

This is not breaking

It's a binary-breaking change

@MikeAlhayek
Copy link
Member Author

@hishamco
OC.Rules depends on OC.Rules.Core so if someone already depend on OC.Rules, they they'll have access to everything in OC.Rules.Core so it won't have any compile or run time errors. So it should not be breaking anyone

@hishamco
Copy link
Member

hishamco commented Apr 3, 2024

OC.Rules.Core so it won't have any compile or run time errors.

I know what you mean, but while you changed the assembly it was considered a binary breaking change, anyhow while we accept the breaking changes in minor releases it's not a problem

Again can we prevent breaking changes in minor releases coz sometimes accept and sometimes not :)

@MikeAlhayek
Copy link
Member Author

@hishamco the only thing that would break is moving the rules to a different project because YesSQL stores the assembly name in the database when it is stored. So I am moving the models back to make sure Yessql won't have serialization problem.

@MikeAlhayek MikeAlhayek requested a review from hishamco April 4, 2024 22:48
MikeAlhayek

This comment was marked as resolved.

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) April 7, 2024 23:54
@MikeAlhayek MikeAlhayek merged commit c3e5393 into main Apr 7, 2024
5 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/rules branch April 7, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants