Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several perf improvements around shape processing #15661

Merged
merged 10 commits into from
Apr 8, 2024
Merged

Several perf improvements around shape processing #15661

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
76f65f9
Improve ShapeBindingStrategyResolver performance
sebastienros Apr 4, 2024
04ff7d8
Skip caching overhead when it is disabled
sebastienros Apr 4, 2024
80e7d61
Reduce ResourceTagHelper allocations
sebastienros Apr 5, 2024
bdad860
Improve ViewEngine DI resolution
sebastienros Apr 5, 2024
1cd8a76
Reduce css class string allocations in ShapeTagBuilder
sebastienros Apr 5, 2024
f11b7fb
Improve dynamic proxy creation performance
sebastienros Apr 5, 2024
4b233b7
Merge branch 'main' into sebros/improvements
sebastienros Apr 5, 2024
001caba
Empty checks
sebastienros Apr 5, 2024
697cbef
Simplify alternates creation
sebastienros Apr 5, 2024
40eda3c
PR feedback
sebastienros Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/OrchardCore/OrchardCore.DisplayManagement/IShape.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Nodes;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc.Rendering;
Expand Down Expand Up @@ -98,12 +99,12 @@ public static TagBuilder GetTagBuilder(this IShape shape, string defaultTagName

var tagBuilder = new TagBuilder(tagName);

if (shape.Attributes != null)
if (shape.Attributes != null && shape.Attributes.Any())
sebastienros marked this conversation as resolved.
Show resolved Hide resolved
{
tagBuilder.MergeAttributes(shape.Attributes, false);
}

if (shape.Classes != null)
if (shape.Classes != null && shape.Classes.Any())
{
// Faster than AddCssClass which will do twice as many concatenations as classes.
tagBuilder.Attributes["class"] = string.Join(' ', shape.Classes);
sebastienros marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading