Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ShapeProxyBenchmark methods static #15696

Closed
wants to merge 1 commit into from

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Apr 9, 2024

(Visual Studio) code analyzer suggestion.

@Skrypt Skrypt requested a review from sebastienros April 9, 2024 01:07
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the benchmarks:

image

Suppress the analyzer for the whole project, together with a comment on why is it necessary, instead. See https://github.com/Lombiq/.NET-Analyzers/blob/dev/Lombiq.Analyzers/Docs/ConfiguringAnalyzers.md#suppressing-analyzers-from-code-for-a-whole-project

@MikeAlhayek
Copy link
Member

I think this will break the benchmarks. Did you try running the benchmarks?

@Piedone
Copy link
Member

Piedone commented Apr 9, 2024

It does, see my comment just above.

@Skrypt Skrypt closed this Apr 9, 2024
@hishamco
Copy link
Member

hishamco commented Apr 9, 2024

Oops, seems I was confused between the benchmarks themselves and the methods utilized by them. So ignore my approval

@Skrypt
Copy link
Contributor Author

Skrypt commented Apr 9, 2024

@Piedone Can you create an issue with your suggestion?

@Piedone
Copy link
Member

Piedone commented Apr 9, 2024

The fix was quicker :) #15707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants