Make ShapeProxyBenchmark methods static #15696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
approved these changes
Apr 9, 2024
Piedone
requested changes
Apr 9, 2024
There was a problem hiding this comment.
This breaks the benchmarks:
Suppress the analyzer for the whole project, together with a comment on why is it necessary, instead. See https://github.com/Lombiq/.NET-Analyzers/blob/dev/Lombiq.Analyzers/Docs/ConfiguringAnalyzers.md#suppressing-analyzers-from-code-for-a-whole-project
|
I think this will break the benchmarks. Did you try running the benchmarks? |
|
It does, see my comment just above. |
|
Oops, seems I was confused between the benchmarks themselves and the methods utilized by them. So ignore my approval |
|
@Piedone Can you create an issue with your suggestion? |
|
The fix was quicker :) #15707 |
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Visual Studio) code analyzer suggestion.