Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating Culture and LocalizationSet #15714

Conversation

M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented Apr 10, 2024

Fixes #15713

@MikeAlhayek MikeAlhayek changed the title Fix Issue-15713: Fix creating Culture and LocalizationSet Fix creating Culture and LocalizationSet Apr 12, 2024
@MikeAlhayek MikeAlhayek requested a review from hishamco April 12, 2024 22:48
@hishamco
Copy link
Member

@MikeAlhayek I'm waiting to reply for my comment here then we can decide if it's the right fix

@Piedone
Copy link
Member

Piedone commented May 2, 2024

Any news with the review here, @hishamco?

@hishamco
Copy link
Member

hishamco commented May 2, 2024

I was waiting for clean steps to reproduce the issue, but here the author shows a sample method, so I can't reproduce the bug

@hishamco
Copy link
Member

hishamco commented May 2, 2024

@all-contributors please add @M-Lipin

Copy link
Contributor

@hishamco

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@hishamco
Copy link
Member

hishamco commented May 2, 2024

@Piedone why it doesn't add it as a contributor, or it should be done after the merge

@Piedone
Copy link
Member

Piedone commented May 2, 2024

M-Lipin is already listed as a contributor: https://docs.orchardcore.net/en/latest/community/contributors/ But otherwise it's something like https://github.com/all-contributors please add @M-Lipin for code (not "for code"). But you don't need this, first-time contributors are now automatically added by https://github.com/OrchardCMS/OrchardCore/actions/runs/8928186758/workflow.

@hishamco
Copy link
Member

hishamco commented May 2, 2024

I just noticed him for the first time, thanks

Do you have anything else to add to this PR or shall I merge

@Piedone
Copy link
Member

Piedone commented May 2, 2024

I wouldn't review if you're OK with it unless you insist on having a second opinion.

@hishamco hishamco merged commit 117b298 into OrchardCMS:main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Culture and LocalizationSet are not set for LocalizationPart if content is created programmatically
3 participants