Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce contention by caching shellsetting accessors #15728

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

sebastienros
Copy link
Member

Accessing the Configuration object is expensive as it's querying all providers on each accessor and locking on it.

Before

image

After

image

Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization

@MikeAlhayek MikeAlhayek merged commit b1b4717 into main Apr 12, 2024
5 checks passed
@MikeAlhayek MikeAlhayek deleted the sebros/sshellcontention branch April 12, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants