Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh and simplify mkdocs instructions, and fix warnings emitted by mkdocs #15775

Closed
wants to merge 3 commits into from

Conversation

sarahelsaig
Copy link
Contributor

@sarahelsaig sarahelsaig commented Apr 16, 2024

I have noticed that the Running the documentation site locally documentation is a bit complicated. Specifically, altering the PATH is unnecessary, and the instructions still use pip3 instead of pip even though Python 2 has been fully dead since 2020. Also mkdocs' install guide URL has changed.

Additionally, I fixed every INFO and WARN I saw in the mkdocs output, except the "The following pages exist in the docs directory, but are not included in the "nav" configuration." INFO message because I didn't want to alter the nav config.

Excluding the "The following pages exist in the docs directory, but are not included in the "nav" configuration." INFO message.
@sarahelsaig sarahelsaig requested a review from agriffard as a code owner April 16, 2024 18:28
@Piedone
Copy link
Member

Piedone commented Apr 16, 2024

Since I also fixed the warnings under #15695 and changed the contribution docs in #15706, let's merge those first.

@sarahelsaig
Copy link
Contributor Author

Hmm, I didn't realize that it's already being handled. Then how about I open a PR with just the changes in src/docs/topics/docs-contributions/README.md instead?

@sarahelsaig
Copy link
Contributor Author

closed in favor of #15802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants