Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypePartDefinition to BagPartEditViewModel #15798

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

giannik
Copy link
Contributor

@giannik giannik commented Apr 21, 2024

The definition will provide more context for the bag part editor. Usefull for custom editors to get editor specific properties.

The definition will provide more context for the bag part editor.
@Piedone
Copy link
Member

Piedone commented Apr 21, 2024

@MikeAlhayek please merge those PRs that you approve and haven't asked anybody for a second opinion (so we don't get merge conflicts or forget about those). Can this be merged?

@MikeAlhayek
Copy link
Member

This is when you approve and merge :)

@MikeAlhayek MikeAlhayek merged commit 05b79ab into OrchardCMS:main Apr 21, 2024
5 checks passed
@Piedone
Copy link
Member

Piedone commented Apr 21, 2024

I'd only take time doing a second review of a PR if it's actually necessary because you're unsure about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants