Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.3 (Lombiq Technologies: OCORE-162) #15826

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Apr 25, 2024

Fix #15824

@Piedone Piedone marked this pull request as ready for review April 25, 2024 14:17
@Piedone Piedone requested a review from agriffard as a code owner April 25, 2024 14:17
@Piedone Piedone requested review from MikeAlhayek, hishamco and sebastienros and removed request for agriffard April 25, 2024 14:17
@Piedone
Copy link
Member Author

Piedone commented Apr 25, 2024

I'd need an urgent review here, please. Then I'll do the rest of the release.

@Piedone Piedone changed the title Release v1.8.3 Release v1.8.3 (Lombiq Technologies: OCORE-162) Apr 25, 2024
@@ -17,7 +17,7 @@ The below table lists the different .NET libraries used in Orchard Core:
| [Fluid.Core](https://github.com/sebastienros/fluid) | .NET Liquid template engine. | 2.5.0 | [MIT](https://github.com/sebastienros/fluid/blob/dev/LICENSE) |
| [GraphQL](https://github.com/graphql/graphiql) | GraphiQL & GraphQL. | 4.6.1 | [MIT](https://github.com/graphql/graphiql/blob/main/LICENSE) |
| [HtmlSanitizer](https://github.com/mganss/HtmlSanitizer) | Cleans HTML to avoid XSS attacks. | 8.1.812-beta | [MIT](https://github.com/mganss/HtmlSanitizer/blob/master/LICENSE.md) |
| [Image Sharp](https://github.com/SixLabors/ImageSharp.Web) | Middleware for ASP.NET-Core for image manipulation. | 3.1.0 |[Apache-2.0](https://github.com/SixLabors/ImageSharp.Web/blob/master/LICENSE) |
| [ImageSharp](https://github.com/SixLabors/ImageSharp.Web) | Middleware for ASP.NET-Core for image manipulation. | 3.1.2 |[Apache-2.0](https://github.com/SixLabors/ImageSharp.Web/blob/master/LICENSE) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest merging this PR #15822 too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not applicable since those packages are only used in main.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While ImageSharp version is 3.1.2 I think it's updated recently, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand. Note that this is a patch release on top of 1.8.2. Anything done in main since that is intentionally not included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything done in the main since that is intentionally not included.

I see, but how was the ImageShape version updated above, while it was merged last week #15767

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR was merged to main. This PR is not started from main, but release/1.8.3. We don't want to release main, since that contains a lot of stuff for 1.9 and it's not ready yet. We do want to release the two dependency updates in this PR ASAP and not wait for anything else, since they're security vulnerabilities. So, the update to the version of these needed to be done a second time here too.

@@ -8,7 +8,7 @@ The below table lists the different .NET libraries used in Orchard Core:
| [AWSSDK S3](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.104.11 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) |
| [AWSSDK SecurityToken](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.101.60 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) |
| [AWSSDK Extensions Setup](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.7 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) |
| [Azure Identity](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/README.md) | Azure Active Directory token authentication support. | 1.10.4 |[MIT](https://github.com/Azure/azure-sdk-for-net/blob/master/LICENSE.txt) |
| [Azure Identity](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/README.md) | Azure Active Directory token authentication support. | 1.11.2 |[MIT](https://github.com/Azure/azure-sdk-for-net/blob/master/LICENSE.txt) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these changes are coming from an existing PR. I think you should backport that PR into this branch. The Release v1.8.3 PR should contain only administration docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much point in finding those PRs and cherry-picking them for changes in version numbers.

@Piedone Piedone merged commit be675b3 into release/1.8.3 Apr 25, 2024
3 checks passed
@Piedone Piedone deleted the zl/release-1.8.3 branch April 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants