Run Functional Tests - All Databases automatically (Lombiq Technologies: OCORE-167) #15951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
May 2, 2024
|
And it also worked, thanks! |
This was referenced May 2, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are now only run manually, when somebody feels like it. However, then trying to correlate code changes to new bugs can be a lot harder, as we've seen in the examples of #15628 and #15794 which would've been caught by these tests.
So, now that the tests pass, this change makes them trigger on PR reviews being submitted (i.e. when somebody requests changes as well as on approve). This is still a soft guard, since you can merge if they fail (should be rare, but they can be flaky) but at least will help us catch such very fundamental bugs earlier.
Fix #7835