Update Workflow Type #15953
Merged
Update Workflow Type #15953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
May 2, 2024
src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs
Show resolved
Hide resolved
Piedone
requested changes
May 3, 2024
src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Workflows/Controllers/WorkflowTypeController.cs
Show resolved
Hide resolved
Comment on lines
+128
to
+130
| // Use existing session connection. Do not use 'using' or dispose the connection. | ||
| var connection = await _session.CreateConnectionAsync(); | ||
| var workflowTypeIdsWithInstances = (await connection.QueryAsync<string>(sqlBuilder.ToSqlString(), param: null, _session.CurrentTransaction)).ToList(); |
There was a problem hiding this comment.
These changes look OK but how do they fix the issue?
There was a problem hiding this comment.
I don't know if it did or not. The issue in production happens randomly which is really hard to reproduce. But this is the only suspicious code since it's the only place to try to reuse the current connection. In production, the issue seems to happen when we list the workflow types. I think the fact we could be writing data to the current transaction and then read on the same connection seems that we should be passing the transaction.
There was a problem hiding this comment.
Hmm, OK, this won't hurt, but I really don't see what here would fix the exception. BTW this might be related: #15290.
Piedone
approved these changes
May 3, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Piedone I am not sure if this is going to fix the issue we are seeing. But I think we should pass the current transaction to that query because the Query may flush any data associated with that transaction.
Unless you see an issue here, I would like to take this change and test it out. It's not easy to detect the problem since it's not consistent.