Adds more features back that were lost due to the removal of Newtonsoft #16292

gvkries · 2024-06-11T12:15:40Z

Added ToObject<T> implementations back to JsonDynamicObject, JsonDynamicArray and JsonDynamicValue.
This functionality allows to convert JSON to the strongly typed content items and parts when using dynamic typing. E.g. we have this functionality referenced in the documentation:

OrchardCore/src/docs/reference/modules/Media/README.md

Line 456 in 7196b5b

    
           var anchors = (Anchor[])Model.ContentItem.Content.Blog.Image.Anchors.ToObject<Anchor[]>();

Also something like the following is now possible again:

@foreach (var blogPost in Model.ContentItem.Content.NamedBagPart.ContentItems)
{
    var contentItem = blogPost.ToObject<ContentItem>();
    
    [...]
}

To support value comparisons when using dynamic typing, I made the following changes:

Implemented equality operators in JsonDynamicValue.
Added implicit conversions from base types to JsonDynamicValue.
Implemented IComparable in JsonDynamicValue.

E.g. this allows using conditions with dynamic values, without casting to the target type before:

dynamic blogPost = ...;
if (blogPost.BlogPost.Subtitle.Text == "Test") {... }

Note that the comparison implementation (<, >, <=, >=) is very basic at the moment, e.g. it does not handle all types
a JsonDynamicValue can be converted too. The comparison was therefore supporting a wider range
of target types with Newtonsoft JSON, in contrast to this rudimentary implementation.

Fixes #16233
Fixes #16221
~~Fixes #16290~~

/cc @giannik @MikeAlhayek @sebastienros

…pers, that where lost by removing Newtonsoft.

MikeAlhayek

LGTM. If you are able to, it may not be a bad idea to add functional tests for this to ensure everything is working and will continue to work as expected.

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

hyzx86 · 2024-06-11T13:40:37Z

The unit test I mentioned in issue #16290 doesn't work with this PR , any plans to fix it in this PR?

Can we modify the DynamicJsonValue fetching behaviour so that it can be generated from the JsonValueKind enumeration, e.g.

JsonValueKind.String map to System.
JsonValueKind.Number map to Decimal.
JsonValueKind.Object map to DynamicJsonValue.
...others

I'm working on that.

hyzx86 · 2024-06-11T14:30:58Z

Similar functionality exists in Jint and ClearScript, Jint uses ExpandoObject, but ClearScript uses DynamicObject.
Shall we try ExpandoObject as well? I've tried using ClearScript before because of the same type conversion or value compatibility issues.

microsoft/ClearScript#485

…micValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>

sebastienros · 2024-06-11T18:03:35Z

Dude you are so cool, but even more if you create a unit test with these conversions ;)

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

hishamco · 2024-06-12T05:32:29Z

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

+    public static bool operator !=(JsonDynamicValue left, JsonDynamicValue right)
+    {
+        return !(left == right);
+    }


Suggested change

public static bool operator !=(JsonDynamicValue left, JsonDynamicValue right)

{

return !(left == right);

}

public static bool operator !=(JsonDynamicValue left, JsonDynamicValue right) => !(left == right);

I know you prefer expression bodies, but Sebastien removed all of them the last time this file was changed. So I rather keep the format consistent for now.

I confirm. When I tried to open the classes and read what they were doing it was so condensed I couldn't understand what I was reading.

What I realized is that if the definition + body fits on a line on the screen then it's fine, if the implementation has to go on the second line then there is no point and it's more readable to just use a standard body.

But please don't change anything because "that one char can be removed and it will fit in a single line", there is no readability advantage IMO by squashing everything in a line.

hishamco · 2024-06-12T05:33:01Z

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

+    public static bool operator <(JsonDynamicValue left, JsonDynamicValue right)
+    {
+        return ReferenceEquals(left, null) ? !ReferenceEquals(right, null) : left.CompareTo(right) < 0;
+    }


Suggested change

public static bool operator <(JsonDynamicValue left, JsonDynamicValue right)

{

return ReferenceEquals(left, null) ? !ReferenceEquals(right, null) : left.CompareTo(right) < 0;

}

public static bool operator <(JsonDynamicValue left, JsonDynamicValue right)

=> ReferenceEquals(left, null) ? !ReferenceEquals(right, null) : left.CompareTo(right) < 0;

hishamco · 2024-06-12T05:33:48Z

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

+    public static bool operator <=(JsonDynamicValue left, JsonDynamicValue right)
+    {
+        return ReferenceEquals(left, null) || left.CompareTo(right) <= 0;
+    }
+
+    public static bool operator >(JsonDynamicValue left, JsonDynamicValue right)
+    {
+        return !ReferenceEquals(left, null) && left.CompareTo(right) > 0;
+    }
+
+    public static bool operator >=(JsonDynamicValue left, JsonDynamicValue right)
+    {
+        return ReferenceEquals(left, null) ? ReferenceEquals(right, null) : left.CompareTo(right) >= 0;
+    }


Suggested change

public static bool operator <=(JsonDynamicValue left, JsonDynamicValue right)

{

return ReferenceEquals(left, null) || left.CompareTo(right) <= 0;

}

public static bool operator >(JsonDynamicValue left, JsonDynamicValue right)

{

return !ReferenceEquals(left, null) && left.CompareTo(right) > 0;

}

public static bool operator >=(JsonDynamicValue left, JsonDynamicValue right)

{

return ReferenceEquals(left, null) ? ReferenceEquals(right, null) : left.CompareTo(right) >= 0;

}

public static bool operator <=(JsonDynamicValue left, JsonDynamicValue right)

=> ReferenceEquals(left, null) || left.CompareTo(right) <= 0;

public static bool operator >(JsonDynamicValue left, JsonDynamicValue right)

=> !ReferenceEquals(left, null) && left.CompareTo(right) > 0;

public static bool operator >=(JsonDynamicValue left, JsonDynamicValue right)

=> ReferenceEquals(left, null) ? ReferenceEquals(right, null) : left.CompareTo(right) >= 0;

hishamco · 2024-06-12T05:43:16Z

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicValue.cs

+
+    public static implicit operator JsonDynamicValue(short? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(int value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(int? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(long value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(long? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(sbyte value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(sbyte? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(float value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(float? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(string value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(ushort value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(ushort? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(uint value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(uint? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(ulong value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(ulong? value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(byte[] value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(Convert.ToBase64String(value), JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(TimeSpan value)
+    {
+        return new JsonDynamicValue(JsonValue.Create(value.ToString(), JOptions.Node));
+    }
+
+    public static implicit operator JsonDynamicValue(TimeSpan? value)
+    {
+        return new JsonDynamicValue(value.HasValue ? JsonValue.Create(value.ToString(), JOptions.Node) : null);
+    }
+
+    public static implicit operator JsonDynamicValue(Uri? value)
+    {
+        return new JsonDynamicValue(value != null ? JsonValue.Create(value.ToString(), JOptions.Node) : null);
+    }


Suggested change

public static implicit operator JsonDynamicValue(bool value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(bool? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(byte value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(byte? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(char value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(char? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(DateTime value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(DateTime? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(DateTimeOffset value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(DateTimeOffset? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(decimal value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(decimal? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(double value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(double? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(Guid value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(Guid? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(short value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(short? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(int value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(int? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(long value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(long? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(sbyte value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(sbyte? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(float value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(float? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(string value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(ushort value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(ushort? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(uint value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(uint? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(ulong value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(ulong? value)

{

return new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

}

public static implicit operator JsonDynamicValue(byte[] value)

{

return new JsonDynamicValue(JsonValue.Create(Convert.ToBase64String(value), JOptions.Node));

}

public static implicit operator JsonDynamicValue(TimeSpan value)

{

return new JsonDynamicValue(JsonValue.Create(value.ToString(), JOptions.Node));

}

public static implicit operator JsonDynamicValue(TimeSpan? value)

{

return new JsonDynamicValue(value.HasValue ? JsonValue.Create(value.ToString(), JOptions.Node) : null);

}

public static implicit operator JsonDynamicValue(Uri? value)

{

return new JsonDynamicValue(value != null ? JsonValue.Create(value.ToString(), JOptions.Node) : null);

}

public static implicit operator JsonDynamicValue(bool value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(bool? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(byte value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(byte? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(char value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(char? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(DateTime value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(DateTime? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(DateTimeOffset value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(DateTimeOffset? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(decimal value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(decimal? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(double value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(double? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(Guid value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(Guid? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(short value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(short? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(int value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(int? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(long value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(long? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(sbyte value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(sbyte? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(float value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(float? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(string value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(ushort value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(ushort? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(uint value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(uint? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(ulong value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(ulong? value)

=> new JsonDynamicValue(JsonValue.Create(value, JOptions.Node));

public static implicit operator JsonDynamicValue(byte[] value)

=> new JsonDynamicValue(JsonValue.Create(Convert.ToBase64String(value), JOptions.Node));

public static implicit operator JsonDynamicValue(TimeSpan value)

=> new JsonDynamicValue(JsonValue.Create(value.ToString(), JOptions.Node));

public static implicit operator JsonDynamicValue(TimeSpan? value)

=> new JsonDynamicValue(value.HasValue ? JsonValue.Create(value.ToString(), JOptions.Node) : null);

public static implicit operator JsonDynamicValue(Uri? value)

=> new JsonDynamicValue(value != null ? JsonValue.Create(value.ToString(), JOptions.Node) : null);

Added unit tests.

…dCore into gvkries/dyn-16233

gvkries · 2024-06-12T09:44:08Z

I added some basic unit tests for the new implicit conversions and operators.

Also, to make it even more complex, I added a fix for #16290 into this PR. Serializing the dynamic wrappers (JsonDynamicObject, JsonDynamicArray and JsonDynamicValue) should not include these objects in the output at all. They should be transparent for users, the same way as it was with NSJ, where we didn't had this extra abstraction layer.

…micValue.cs Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>

hyzx86 · 2024-06-12T11:54:21Z

I've tested it and found that it's still a little different from the old version, but it's almost complete. Thanks!

const content = contentItem('46t41hp7d9w6446r35405swzwt')

return {
    data: {
        // contentStr:JSON.stringify(content), //Error: Cyclic reference detected
        testValue: content.Content.SEAQuotaionForm.SoldTo.Text,
        testValue2: content.Content.SEAQuotaionForm.SoldTo.Text + "2123",
        QuoteId: content.Content.SEAQuotaionForm.QuoteId.Value + 10000,
        obj: JSON.parse(JSON.stringify(content.Content)),
        objStr: JSON.stringify(content.Content),
        objAll: content
    }
}

this PR

this is oc 1.8

hyzx86 · 2024-06-12T11:59:22Z

I should try the datetime value again later.

gvkries · 2024-06-12T15:05:37Z

I think in Jint you have the same problem. The dynamic wrappers are now also serialized, that's why you get a different result. The JsonDynamicObject only has the Count property public, and that's getting serialized.

hyzx86 · 2024-06-12T17:16:56Z

I think in Jint you have the same problem. The dynamic wrappers are now also serialized, that's why you get a different result. The JsonDynamicObject only has the Count property public, and that's getting serialized.

Yes, in my tests the serialisation converter you defined works in Jint

hyzx86 · 2024-06-12T18:49:10Z

I created a PR for solving serialisation problems in Jint #16298

…ions.

gvkries · 2024-06-13T11:38:50Z

I simplified this a little bit by adding a base class for the dynamic wrappers (as @hishamco suggested). Also, I removed the nested JsonDynamicMetaObject class as it is not required.

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs

sebastienros · 2024-06-13T17:50:11Z

@MikeAlhayek @hishamco waiting for you asking for more things, or we'll merge in 24h.

MikeAlhayek

LGTM

test/OrchardCore.Tests/Data/JsonDynamicTests.cs

hishamco · 2024-06-15T17:57:59Z

@sebastienros if there's any objection regarding expression bodies please let me, because it was a useful feature for single-line methods

hyzx86 · 2024-06-18T04:33:47Z

@sebastienros if there's any objection regarding expression bodies please let me, because it was a useful feature for single-line methods

Personally, it's not a big deal, and I'm more than inclined to prioritise readability, too
The more urgent thing right now should be to resolve the remaining almost 1000 issues 😅
If nothing else is added, I suggest merging it as soon as possible

hishamco · 2024-06-18T08:18:19Z

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs

+    public void Merge(JsonNode? content, JsonMergeSettings? settings = null)
+    {
+        _jsonObject.Merge(content, settings);
+    }


Suggested change

public void Merge(JsonNode? content, JsonMergeSettings? settings = null)

{

_jsonObject.Merge(content, settings);

}

public void Merge(JsonNode? content, JsonMergeSettings? settings = null) => _jsonObject.Merge(content, settings);

hishamco · 2024-06-18T08:19:12Z

src/OrchardCore/OrchardCore.Abstractions/Json/Serialization/JsonDynamicJsonConverter.cs

+    public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+    {
+        throw new NotSupportedException($"Deserializing a {typeof(T).Name} is not supported.");
+    }


Suggested change

public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

{

throw new NotSupportedException($"Deserializing a {typeof(T).Name} is not supported.");

}

public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)

=> throw new NotSupportedException($"Deserializing a {typeof(T).Name} is not supported.");

test/OrchardCore.Tests/Data/JsonDynamicTests.cs

hyzx86 · 2024-06-26T16:17:14Z

A week has passed. Nothing for now, is it mandatory that we use expression ? 🤨

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>

gvkries · 2024-06-26T16:36:55Z

I don't see the remaining formatting suggestions as mandatory... 🙈

hyzx86 · 2024-06-26T16:42:09Z

Hi @hishamco ，All right, all right, let's merge it quickly.

giannik · 2024-06-26T16:51:29Z

merge, merge...

MikeAlhayek · 2024-06-26T17:30:36Z

@gvkries I enabled auto merge. Hopefully you are done making changes :)

sebastienros · 2024-06-27T06:13:17Z

@sebastienros if there's any objection regarding expression bodies please let me, because it was a useful feature for single-line methods

I have stated my "personal" preferences and motivations several times already.

gvkries added 2 commits June 11, 2024 14:04

Adds missing features back to JsonDynamicValue and other dynamic wrap…

354e3bf

…pers, that where lost by removing Newtonsoft.

Merge branch 'main' into gvkries/dyn-16233

caabce8

This was referenced Jun 11, 2024

Convert jsonDynamic to contentitem extension #16283

Closed

Getting value from JsonDynamicValue in Jint #16290

Closed

MikeAlhayek requested changes Jun 11, 2024

View reviewed changes

sebastienros and others added 4 commits June 11, 2024 10:59

Update src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDyna…

8a47148

…micValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>

Update src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDyna…

1527ee3

…micValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>

Update src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDyna…

fdb3cf0

…micValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>

Formatting

0befa3e

hishamco requested changes Jun 12, 2024

View reviewed changes

gvkries mentioned this pull request Jun 12, 2024

Fix dynamic field value issues #16294

Closed

gvkries added 2 commits June 12, 2024 11:37

Added JsonConverters for the dynamic wrappers.

de86c47

Added unit tests.

Merge branch 'gvkries/dyn-16233' of https://github.com/gvkries/Orchar…

e7dce82

…dCore into gvkries/dyn-16233

Update src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDyna…

826aac9

…micValue.cs Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>

hyzx86 mentioned this pull request Jun 12, 2024

Fix JsonDynamic related object serialisation problem in Jint. #16298

Merged

Merge branch 'main' into gvkries/dyn-16233

24278fa

hyzx86 approved these changes Jun 13, 2024

View reviewed changes

Added a base class for dynamic wrappers and did some code simplificat…

647aa64

…ions.

gvkries requested review from hyzx86 and sebastienros June 13, 2024 11:40

sebastienros reviewed Jun 13, 2024

View reviewed changes

src/OrchardCore/OrchardCore.Abstractions/Json/Dynamic/JsonDynamicObject.cs Outdated Show resolved Hide resolved

gvkries added 2 commits June 13, 2024 18:31

Make classes sealed.

165678d

Merge branch 'main' into gvkries/dyn-16233

4802519

sebastienros approved these changes Jun 13, 2024

View reviewed changes

MikeAlhayek approved these changes Jun 13, 2024

View reviewed changes

test/OrchardCore.Tests/Data/JsonDynamicTests.cs Outdated Show resolved Hide resolved

MikeAlhayek added 2 commits June 13, 2024 10:55

Merge branch 'main' into gvkries/dyn-16233

e38f3ba

Update JsonDynamicTests.cs

7f4ddc3

sebastienros reviewed Jun 13, 2024

View reviewed changes

test/OrchardCore.Tests/Data/JsonDynamicTests.cs Show resolved Hide resolved

Merge branch 'main' into gvkries/dyn-16233

d114076

Merge branch 'main' into gvkries/dyn-16233

6548bba

hishamco requested changes Jun 18, 2024

View reviewed changes

gvkries and others added 2 commits June 26, 2024 18:31

Merge branch 'main' into gvkries/dyn-16233

9dcafc2

Update test/OrchardCore.Tests/Data/JsonDynamicTests.cs

4d7b6a6

Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>

Update test/OrchardCore.Tests/Data/JsonDynamicTests.cs

6afae02

hishamco approved these changes Jun 26, 2024

View reviewed changes

Update JsonDynamicTests.cs

2156020

MikeAlhayek enabled auto-merge (squash) June 26, 2024 17:29

MikeAlhayek merged commit 51eb7b8 into OrchardCMS:main Jun 26, 2024
5 checks passed

This was referenced Jul 1, 2024

Monthly community metrics report for 2024-06-01..2024-06-30 SGuidone/OrchardCore#45

Open

Monthly community metrics report for 2024-06-01..2024-06-30 #16387

Closed

gvkries deleted the gvkries/dyn-16233 branch July 1, 2024 12:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds more features back that were lost due to the removal of Newtonsoft #16292

Adds more features back that were lost due to the removal of Newtonsoft #16292

gvkries commented Jun 11, 2024 •

edited

Loading

MikeAlhayek left a comment

hyzx86 commented Jun 11, 2024 •

edited

Loading

hyzx86 commented Jun 11, 2024 •

edited

Loading

sebastienros commented Jun 11, 2024

hishamco Jun 12, 2024

gvkries Jun 12, 2024

sebastienros Jun 13, 2024

sebastienros Jun 13, 2024

hishamco Jun 12, 2024

hishamco Jun 12, 2024

hishamco Jun 12, 2024

gvkries commented Jun 12, 2024

hyzx86 commented Jun 12, 2024 •

edited

Loading

hyzx86 commented Jun 12, 2024

gvkries commented Jun 12, 2024

hyzx86 commented Jun 12, 2024

hyzx86 commented Jun 12, 2024

gvkries commented Jun 13, 2024

sebastienros commented Jun 13, 2024

MikeAlhayek left a comment

hishamco commented Jun 15, 2024

hyzx86 commented Jun 18, 2024

hishamco Jun 18, 2024

hishamco Jun 18, 2024

hyzx86 commented Jun 26, 2024 •

edited

Loading

gvkries commented Jun 26, 2024

hyzx86 commented Jun 26, 2024

giannik commented Jun 26, 2024

MikeAlhayek commented Jun 26, 2024

sebastienros commented Jun 27, 2024

Adds more features back that were lost due to the removal of Newtonsoft #16292

Adds more features back that were lost due to the removal of Newtonsoft #16292

Conversation

gvkries commented Jun 11, 2024 • edited Loading

MikeAlhayek left a comment

Choose a reason for hiding this comment

hyzx86 commented Jun 11, 2024 • edited Loading

hyzx86 commented Jun 11, 2024 • edited Loading

sebastienros commented Jun 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gvkries commented Jun 12, 2024

hyzx86 commented Jun 12, 2024 • edited Loading

hyzx86 commented Jun 12, 2024

gvkries commented Jun 12, 2024

hyzx86 commented Jun 12, 2024

hyzx86 commented Jun 12, 2024

gvkries commented Jun 13, 2024

sebastienros commented Jun 13, 2024

MikeAlhayek left a comment

Choose a reason for hiding this comment

hishamco commented Jun 15, 2024

hyzx86 commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyzx86 commented Jun 26, 2024 • edited Loading

gvkries commented Jun 26, 2024

hyzx86 commented Jun 26, 2024

giannik commented Jun 26, 2024

MikeAlhayek commented Jun 26, 2024

sebastienros commented Jun 27, 2024

gvkries commented Jun 11, 2024 •

edited

Loading

hyzx86 commented Jun 11, 2024 •

edited

Loading

hyzx86 commented Jun 11, 2024 •

edited

Loading

hyzx86 commented Jun 12, 2024 •

edited

Loading

hyzx86 commented Jun 26, 2024 •

edited

Loading