Added option to select the Target in Link Field

[vengi83644]

Fixes #16244

[vengi83644]

#16244

[hishamco]

@MikeAlhayek waiting for your approval or I will merge tonight

[sebastienros]

Don't we need to update the migration if there is a new field in the index table?
Do we really need to index link targets? Is there any business need to query links by their html target?

[vengi83644]

We had a situation where we wanted to know how and where we used external links in our pages. One example page is this https://worldatwork.org/events

I missed the migrations. I will create a PR soon.

[sebastienros]

I feel like this is mixing business and ui logic. I would assume these kind of links are specific to a very special kind of entity it's describing, and the fact this external link is opening in a new window is just based on this flag. For instance, a "Vendor" could be "External" and based on that the link to the vendor should use a "_blank" link.

This not only would feel right (ok this is a personal opinion) but this would not require this "niche" feature (indexing UI values). Otherwise this opens us to accepting everything in the index.

[sebastienros]

@vengi83644 just to try to prove my point, where in your site, as a user, do I see the list of the things that are filtered by this new indexed value? Like is there a page of specific things that open in _blank, or a checkbox/filter for that?

[MikeAlhayek]

@sebastienros I think we should have the Target as settings but there is no need for indexing it.

[vengi83644]

@sebastienros @MikeAlhayek @Piedone We let our content authors get reports from the CMS for various use cases - examples: contents using certain widgets, certain content types with their title and description, contents of widgets used in different content types, a typical SEO report. Below is the screenshot of the page,

I am OK with removing the field from the index as it's not a use case for the larger audience. Thanks.

[Piedone]

OK, thanks, we're removing it, then. Please follow Sebastien's above recommendations instead.