Add QueryJsonConverter #16381
Closed
Add QueryJsonConverter #16381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeAlhayek i tried it out but no effect. I think it has to do with that when you disable eg the lucene feature then these rules are not available : so it doesnt know how to deserialize. |
|
one sensible thing would be to load and deserialize only the query documents that are enabled . ignoring others |
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16372
@giannik can you text this PR out please? I think the issue is not due to enable/disable the feature. It has to do with deserializing Query from the data in your database. I think this PR will fix the issue but don't have a way to test it.