Fix non-debug version loaded for certain static resources when debug mode is enabled #16406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Jul 7, 2024
src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/RequireSettings.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.ResourceManagement.Abstractions/RequireSettings.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
hishamco
approved these changes
Jul 7, 2024
|
@Piedone do you have anything else to add or shall I merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16401
This fix addresses an issue where
ResourceManagementOptionswere not inherited by dependent resources. As a result, dependencies were always loaded in their minified versions without versioning. The following images illustrate the changes:Before:
After: