Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jint #16471

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Update Jint #16471

merged 1 commit into from
Jul 22, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

These simple updates are done by Dependabot: https://github.com/OrchardCMS/OrchardCore/pulls?q=is%3Apr+is%3Aclosed+label%3A.NET Oddly enough though, no updates for two weeks now (should be weekly).

@MikeAlhayek
Copy link
Member Author

I did not know we have an action that does this.

The history shows

Errored with the message "Dependabot timed out during its update"

Maybe we can increase the frequency to every 3 day too

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

That would explain it, but where do you see that history?

@MikeAlhayek
Copy link
Member Author

Click on Insights tab. From the left menu, click on Dependency graph then click on Dependabot tab.

https://github.com/OrchardCMS/OrchardCore/network/updates

image

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

Ah, thanks. Why on earth would one put it there and not under https://github.com/OrchardCMS/OrchardCore/security where all the other Dependabot configs are?!

@Piedone Piedone merged commit 757e40e into main Jul 22, 2024
12 checks passed
@Piedone Piedone deleted the ma/update-jint branch July 22, 2024 19:00
@MikeAlhayek
Copy link
Member Author

I think because dependabot is not a standard action. But should be at least referenced in the actions list as a non-standard action

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

I'm looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants