Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid recipe files from breaking the harvester #16490

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek MikeAlhayek requested a review from Piedone July 26, 2024 16:00
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell about a scenario where it's better to ignore the faulty recipe rather than breaking altogether? The latter seems to be more visible to me, and recipes, as basically code files, mustn't be faulty.

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Jul 26, 2024

Can you tell about a scenario where it's better to ignore the faulty recipe rather than breaking altogether? The latter seems to be more visible to me, and recipes, as basically code files, mustn't be faulty.

@Piedone I had multiple startup recipes in a module. The first one has a JSON issue, so none of them were listed in the add tenant. They all failed because one of them throw an exception.

Ignoring and logging the faulty recipes would be better in this case since we would have more info on the faulty recipe and only the bad one is ignored not all of them.

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@MikeAlhayek MikeAlhayek merged commit 417e2ef into main Jul 26, 2024
11 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/log-recipe-files-failing-desc branch July 26, 2024 17:28
hyzx86 pushed a commit to hyzx86/OrchardCore that referenced this pull request Jul 30, 2024
…6490)

---------

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants