Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define formatting rules #16567

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Define formatting rules #16567

merged 3 commits into from
Aug 15, 2024

Conversation

sebastienros
Copy link
Member

Tested with dotnet 8 and dotnet 9 (which adds way more warnings by default, hence these rules).

I tried to disambiguate what contributors hesitate on. For instance method bodies. Now they are fine when fitting a single line. Some things are silent when we do not care much.

The changes in the PR reflect the settings, so that's a good thing to look at to understand the configuration.

Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing

@MikeAlhayek
Copy link
Member

I haven't checked. It's possible that client already pass a view model to the call and it may still be there because it was used at some point. Now if you remove the argument the behavior is different as passing something invalid would not fail without it. It's a breaking change to remove the argument.

I don't think this is the case here LayersIndexViewModel does not do any validation. It's there for binding only and since it's not used. It should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants