Add support for net9.0 #16573
Add support for net9.0 #16573
Conversation
|
Is this will be a part of OC |
|
@hishamco I hope we ship 2.0 before dotnet ships .NET 9 |
|
There are a few changes we might want to take in 2.0 instead of this PR. Mostly all the code changes (formatting and obsolete method). |
|
I think we should at least run the build and test the pipeline with .net 9 just to make sure we don't have anything to report. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
sebastienros
force-pushed
the
sebros/net90
branch
from
7da7af2
to
fe5a020
Compare
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
@hishamco i suggest that you don't merge main on PR others are constantly working on. Let them do that if they choose to do it "when they are ready for it" |
|
I just do it when there's a conflict |
|
I suggest you leave that work for the PR author. Let them work on their own code and resolve their own conflict. |
|
It's not big, this could happen occasionally, see #4466. I don't know what's the issue if you want anyone update branch in your PRs let me know :) |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
resolved conflicts |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
Fixed a conflict |
|
@hishamco I only did it because one my my PR's caused a conflict in this PR so I fixed it. I did not do it accidentally or just because I felt like it. |
|
No problem bro :) |
sebastienros
force-pushed
the
sebros/net90
branch
from
7be3b2d
to
6fcae5e
Compare
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Keeping track of all the tasks when adding/removing a TFM (please update so we can document it):
global.jsonto the require SDK version.src/OrchardCore.Build/TargetFrameworks.props.AspNetCorePackagesVersionfor each TFM inDirectory.Packages.propsuses: actions/setup-dotnet@v4tasks to the required SDK version.dotnet publish,dotnet buildanddotnet testcalls to the latest TFM, if specified.tasks.jsonfiles to target the latest TFMtemplate.jsonfiles).<TargetFramework>).