Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validation error rendering on radio/checkbox #16631

Closed
wants to merge 8 commits into from
Closed

Conversation

ns8482e
Copy link
Contributor

@ns8482e ns8482e commented Aug 28, 2024

fix validation error rendering on radio/checkbox
Before
image

After

image

@hishamco
Copy link
Member

Oops, there's an error in testing assets

@ns8482e
Copy link
Contributor Author

ns8482e commented Aug 28, 2024

Oops, there's an error in testing assets

updated assets

@MikeAlhayek
Copy link
Member

@ns8482e you'll need to run gulp rebuild-assets on your machine and commit the generated files.

You can also try running npm run cleanup all && npm install && gulp rebuild and commit the files

@Piedone
Copy link
Member

Piedone commented Aug 29, 2024

See https://docs.orchardcore.net/en/latest/guides/gulp-pipeline/#using-the-command-line and be sure to use Node.js 18. Before requesting review again, make sure to revert all the unnecessary file changes so only the SCSS one remains.

@ns8482e
Copy link
Contributor Author

ns8482e commented Aug 29, 2024

Yes! something is not right, I am using windows 😂

I build all this in fresh brach from main all cleaned and rebuild as @MikeAlhayek suggested

I'll try with fresh clone too

@ns8482e ns8482e closed this Aug 29, 2024
@MikeAlhayek MikeAlhayek reopened this Aug 29, 2024
@MikeAlhayek
Copy link
Member

I spent some time on this. no luck. I don't have more time to keep trying. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants