Cache Top-unread notification in the navar for better performance. #16641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/OrchardCore.Modules/OrchardCore.Notifications/Drivers/NotificationNavbarDisplayDriver.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Notifications.Core/Extensions/CacheTagExtensions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Notifications.Core/Models/NotificationOptions.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.Notifications.Core/OrchardCore.Notifications.Core.csproj
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Aug 31, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the unread notification on every request is costly on database severs. In this PR, we improve performance by caching the unread notification for the user by default.
Also, we use compiled query to query the database to help SQL Server to not generate an execution place on every query.