-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content shape alternate targeting a specific item with ContentItemId (#15572) #16679
base: main
Are you sure you want to change the base?
Content shape alternate targeting a specific item with ContentItemId (#15572) #16679
Conversation
Introduce new template alternates in Shapes.cs for content items based on `ContentItemId`: - `Content__[ContentItemId]` - `Content_[DisplayType]__[ContentItemId]` Update README.md to document the new alternates, including: - Descriptions of when each template is called - Examples of template filenames - Notes on deprecation of `Id` based templates, recommending `ContentItemId` based templates instead
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. |
Fixes following issue: |
I'm out until Harvest and won't be able to review, trust your judgement @hishamco. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the PR, but am only adding the release notes note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has merge conflicts. Please resolve those before requesting a review. |
Please resolve the conflict |
Conflicts have been resolved. |
I'm not reviewing but @hishamco please finish yours. |
@dmourtzoukos If you please add notes about this change in https://github.com/OrchardCMS/OrchardCore/blob/main/src/docs/releases/3.0.0.md I will merge it for you. Please add the note and request my review so I can merge it. |
@dmourtzoukos please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Do we really need this since we have alias and route shapes? I am thinking this would just create extraneous alternates for every single content item that would probably be unnecessary. |
@sebastienros same feeling here. However, others seems to want it. If it is not really needed, I rather not add it |
The issues were created before we had alias/route alternates, maybe we should ask again. |
You are right, now that we have alternates by alias this PR has no added value. |
@MichaelPetrinolis can you file an issue? Also here is a previous mention of this, check the whole thread there are other alternatives. #5033 (comment) It's not that easy though, perf implications (even more that this PR) |
This pull request enhances the templating system for content items by adding support for templates based on
ContentItemId
and updating the documentation to reflect these changes. The most important changes include the addition of new template alternates in theShapes.cs
file and the corresponding updates in the documentation.Enhancements to templating system:
src/OrchardCore.Modules/OrchardCore.Contents/Shapes.cs
: Added new template alternates forContentItemId
andDisplayType
combined withContentItemId
. This allows for more granular control over content item templates.Documentation updates:
src/docs/reference/modules/Templates/README.md
: Updated the documentation to include examples and descriptions for the new template alternates based onContentItemId
andDisplayType
combined withContentItemId
.Fixes #15572.