Move permissions to its own class to avoid module to module reference #16769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hishamco please document the changes in this PR. We need to make sure that developers have a migration path from one class to another. For example: The This way developers have a reference to refer to if there are using these permissions into their project. |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Search.Elasticsearch/PermissionProvider.cs # src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/ElasticsearchIndexPermissionHelper.cs
|
@hishamco to avoid keep resolving conflicts, please document the changes so we can finalizing it. |
|
Mentioned all relocated permissions will make this too long, we could write one statement and one example to show let the developer aware about the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on updating permission references across multiple files to use new standardized permission classes. The changes are primarily refactoring to replace the old permission references with the new ones.
Fixes #16766