Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the 2.0 release notes #16814

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Clarify the 2.0 release notes #16814

merged 4 commits into from
Oct 1, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@agriffard agriffard changed the title Clerify the 2.0 release notes Clarify the 2.0 release notes Oct 1, 2024
@MikeAlhayek MikeAlhayek requested a review from Piedone October 1, 2024 17:30

- `Display(TSection section, BuildDisplayContext context)`
- `Display(TSection section)`
- `Edit(TSection section, BuildEditorContext context)`
- `UpdateAsync(TSection section, UpdateEditorContext context)`
- `UpdateAsync(TSection section, IUpdateModel updater, string groupId)`

and removed the following methods:
And the following methods have been removed, with updated alternatives:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And the following methods have been removed, with updated alternatives:
The following methods have been removed, with updated alternatives:

Copy link
Member Author

@MikeAlhayek MikeAlhayek Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishamco why do you think this is better? its a continuation of the previous part.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok leave it

@Piedone Piedone merged commit a88dea5 into main Oct 1, 2024
32 checks passed
@Piedone Piedone deleted the ma/update-2.0-release-notes branch October 1, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants