Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dockerfile #16821

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix dockerfile #16821

merged 2 commits into from
Oct 4, 2024

Conversation

sebastienros
Copy link
Member

Fixes #16793

I'd like someone to try it too

docker build .

Piedone
Piedone approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuzzbuzzz @tcobbfis could you please also check?

@fuzzbuzzz
Copy link

hello guys,

I checked this, ALL OK! :D
The Docker build successfully completes, and I'm able to run the app in Docker.

Thank you!

@fuzzbuzzz @tcobbfis could you please also check?

@sebastienros sebastienros merged commit d7a36af into main Oct 4, 2024
6 checks passed
@sebastienros sebastienros deleted the sebros/docker branch October 4, 2024 20:55
This was referenced Nov 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker build error
3 participants
@sebastienros @fuzzbuzzz @Piedone