Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to prevent issues between oc and blazor routing #16835

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

psijkof
Copy link
Contributor

@psijkof psijkof commented Oct 4, 2024

Fixes #16829.

Added extra instructions and explanations about how to avoid issues with oc features and blazor routing (which did pose problems to some users)

Added extra instructions and explanations about how to avoid issues with oc features and blazor routing (which did pose problems  to some users)
@hishamco hishamco requested review from agriffard and ns8482e October 4, 2024 16:22
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@psijkof psijkof requested a review from hishamco October 4, 2024 16:47
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #16829 actually?

src/docs/guides/create-blazor-cms/README.md Outdated Show resolved Hide resolved
@psijkof psijkof requested a review from Piedone October 4, 2024 17:06
@Piedone
Copy link
Member

Piedone commented Oct 4, 2024

You didn't address the code suggestion.

@psijkof
Copy link
Contributor Author

psijkof commented Oct 4, 2024

You didn't address the code suggestion.

I wasn't sure how to request, 'Does this satisfy your review (EDIT: your request for changes)?' :-)

If there is something I could/should do, please tell me.

@Piedone Piedone enabled auto-merge (squash) October 4, 2024 17:38
@Piedone
Copy link
Member

Piedone commented Oct 4, 2024

Commit or argue against the change above:

image

But I've committed it now.

@Piedone Piedone merged commit 17017e3 into OrchardCMS:main Oct 4, 2024
6 checks passed
@psijkof psijkof deleted the patch-1 branch October 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to initialise multitenancy to the Blazor App
3 participants