Check for elastic settings before updating. #16915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
MikeAlhayek
reviewed
Oct 21, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Outdated
Show resolved
Hide resolved
|
@PBMikeW can you also please make the same change here: https://github.com/search?q=repo%3AOrchardCMS%2FOrchardCore%20partDefinition.Settings.Add&type=code |
Skrypt
reviewed
Oct 29, 2024
src/OrchardCore/OrchardCore.Search.Elasticsearch.Core/Services/ElasticIndexingService.cs
Show resolved
Hide resolved
Skrypt
approved these changes
Oct 29, 2024
MikeAlhayek
approved these changes
Oct 29, 2024
|
No, you can merge. |
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone changed a elasticsearch setting on a ContentType then the settings sync no longer worked as the key already exists.