Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Publish Content Task #16962

Closed
wants to merge 6 commits into from
Closed

Fix Publish Content Task #16962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f9d94b
Update DefaultContentManager.cs
AmyBlaine Nov 4, 2024
649f8ee
To publish a content item, it must have a draft
AmyBlaine Nov 4, 2024
f808725
Merge branch 'main' into 16939-publish-content-task
AmyBlaine Nov 6, 2024
13137ad
Merge branch 'main' into 16939-publish-content-task
hishamco Nov 7, 2024
54e39c0
Merge branch 'main' into 16939-publish-content-task
hishamco Nov 8, 2024
ab8e349
Merge branch 'main' into 16939-publish-content-task
AmyBlaine Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/PublishContentTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public override async Task<ActivityExecutionResult> ExecuteAsync(WorkflowExecuti
var content = (await GetContentAsync(workflowContext))
?? throw new InvalidOperationException($"The '{nameof(PublishContentTask)}' failed to retrieve the content item.");

if (string.Equals(InlineEvent.ContentItemId, content.ContentItem.ContentItemId, StringComparison.OrdinalIgnoreCase))
if (!content.HasDraft())
{
return Outcomes("Noop");
}
Expand Down
1 change: 1 addition & 0 deletions src/OrchardCore/OrchardCore.ContentManagement/DefaultContentManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ public async Task CreateAsync(ContentItem contentItem, VersionOptions options =
if (options.IsDraft)
{
contentItem.Published = false;
contentItem.Latest = true;
}

// Build a context with the initialized instance to create
Expand Down