Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Publish Content Task #17033

Merged
merged 1 commit into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public override async Task<ActivityExecutionResult> ExecuteAsync(WorkflowExecuti
var content = (await GetContentAsync(workflowContext))
?? throw new InvalidOperationException($"The '{nameof(PublishContentTask)}' failed to retrieve the content item.");

if (string.Equals(InlineEvent.ContentItemId, content.ContentItem.ContentItemId, StringComparison.OrdinalIgnoreCase))
if (!content.HasDraft())
{
return Outcomes("Noop");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -563,16 +563,17 @@ public async Task CreateAsync(ContentItem contentItem, VersionOptions options =

options ??= VersionOptions.Published;

// Draft flag on create is required for explicitly-published content items
// Draft flag on create is required for explicitly-published content items.
if (options.IsDraft)
{
contentItem.Published = false;
contentItem.Latest = true;
}

// Build a context with the initialized instance to create
// Build a context with the initialized instance to create.
var context = new CreateContentContext(contentItem);

// invoke handlers to add information to persistent stores
// invoke handlers to add information to persistent stores.
await Handlers.InvokeAsync((handler, context) => handler.CreatingAsync(context), context, _logger);

await _session.SaveAsync(contentItem);
Expand All @@ -584,10 +585,10 @@ public async Task CreateAsync(ContentItem contentItem, VersionOptions options =
{
var publishContext = new PublishContentContext(contentItem, null);

// invoke handlers to acquire state, or at least establish lazy loading callbacks
// invoke handlers to acquire state, or at least establish lazy loading callbacks.
await Handlers.InvokeAsync((handler, context) => handler.PublishingAsync(context), publishContext, _logger);

// invoke handlers to acquire state, or at least establish lazy loading callbacks
// invoke handlers to acquire state, or at least establish lazy loading callbacks.
await ReversedHandlers.InvokeAsync((handler, context) => handler.PublishedAsync(context), publishContext, _logger);
}
}
Expand Down