Fixing Queried Content Items query validation (Lombiq Technologies: OCORE-209) #17120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
reviewed
Dec 4, 2024
| @@ -26,7 +26,7 @@ protected override async Task ProcessAsync(QueryBasedContentDeploymentStep step, | |||
| return; | |||
| } | |||
|
|
|||
| if (!query.CanReturnContentItems || !query.ReturnContentItems) | |||
| if (!query.CanReturnContentItems && !query.ReturnContentItems) | |||
There was a problem hiding this comment.
Do we know what is the difference between the CanReturnContentItems and ReturnContentItems?
There was a problem hiding this comment.
CanReturnContentItems seems to me like an abandoned view model property. It's not actually used anywhere, I've removed it.
MikeAlhayek
approved these changes
Dec 5, 2024
|
Yep, and also exported, then imported, all works. |
This was referenced Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17102. The code was originally introduced in #16402. Seems like a no-brainer fix but perhaps I'm not thinking of some gotcha.