-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose properties of ITrackingConsentFeature and cookie policy in Liquid #17148
Expose properties of ITrackingConsentFeature and cookie policy in Liquid #17148
Conversation
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/HttpRequestValue.cs
Show resolved
Hide resolved
IMHO this should be a part of Cookies Consent module |
@hishamco do we have Consent module? We seems to be using the consent interface is multiple places and there isn't a consent module for this. |
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/TrackingConsentValue.cs
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/TrackingConsentValue.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/TrackingConsentValue.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/TrackingConsentValue.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore/OrchardCore.DisplayManagement.Liquid/Values/TrackingConsentValue.cs
Show resolved
Hide resolved
Nope, I already did one, also Lombiq, that's why I'm asking here, unless we could create an abstraction project for it |
Then this PR is good where it is. Feel free to open another PR providing a consent module and move things to it if you add it |
My concern is anyone will add his Liquid filters or tags to be supported in his/her module, which doesn't make sense to me |
If there is already a module, that would be places in its corresponding module. If there isn't one, we can't request the PR creator to create a full blown module just to add Liquid filters. If you create the consent module before releasing v3, we can move this filter there before the release. |
@gvkries it would be nice if you added a Cookie Consent module to make this functional |
…ackingConsentValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>
…ackingConsentValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>
…ackingConsentValue.cs Co-authored-by: Mike Alhayek <mike@crestapps.com>
No, I don't want to duplicate the work that you, Lombiq, and others have already done. This PR only provides the |
Anything else @hishamco ? |
Fixes #17134