Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Microsoft.IdentityModel.Protocols.OpenIdConnect to 8.3.0 and Microsoft.Identity.Web to 3.5.0 #17175

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
Microsoft.IdentityModel.Protocols.OpenIdConnect 8.2.0 -> 8.3.0 age adoption passing confidence

Release Notes

AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet (Microsoft.IdentityModel.Protocols.OpenIdConnect)

v8.3.0

Compare Source

=====

New features

Work related to redesign of IdentityModel's token validation logic #​2711

Bug fixes

Fundamentals

New Contributors

v8.2.1

Compare Source

=====

New features
  • Update to use .NET 9 GA. See 2990.
Bug fixes
  • Remove dependency on Microsoft.Bcl.TimeProvider for .NET 8+ targets. See 2935.
  • Update cgmanifest to align with the JSON schema. See 2969.
Fundamentals
  • Streamline token creation by using SecurityTokenDescriptor. See 2993.
  • Prevent inlining to guarantee stack frames in test. See 2999.
Work related to redesign of IdentityModel's token validation logic #​2711
  • Simplify stack frame caching. See 2976.
  • Implement new model for reading SAML and SAML2 tokens. See 2980.
  • Implement new model for validating SAML signature. See 2950.
  • Add tests for IssuerExtensibility. See 2987.
  • Switch to new validation model for SAML and SAML2 issuer signing key. See 2965.
  • Switch to new validation model for SAML and SAML2 algorithm. See 2984.

Configuration

📅 Schedule: Branch creation - "before 5am on Sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@Piedone Piedone requested a review from kevinchalet December 8, 2024 23:09
@Piedone
Copy link
Member

Piedone commented Dec 8, 2024

Could you please check this and #17174 @kevinchalet and manually fix what we need to do?

@kevinchalet
Copy link
Member

Could you please check this and #17174 @kevinchalet and manually fix what we need to do?

The other PR fails because it bumps Microsoft.Identity.Web but not Microsoft.IdentityModel.Protocols.OpenIdConnect, which is updated separately, in this PR.

I'll close the other one and update this one manually to bump both references, but you should consider configuring the bot to group dependencies updates instead of sending a PR per reference, otherwise it will happen again, and again, and again 😄

Copy link
Contributor

github-actions bot commented Dec 9, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Contributor Author

renovate bot commented Dec 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@kevinchalet kevinchalet changed the title Update dependency Microsoft.IdentityModel.Protocols.OpenIdConnect to 8.3.0 Update dependency Microsoft.IdentityModel.Protocols.OpenIdConnect to 8.3.0 and Microsoft.Identity.Web to 3.5.0 Dec 9, 2024
@kevinchalet kevinchalet merged commit 5360669 into main Dec 9, 2024
7 checks passed
@kevinchalet kevinchalet deleted the renovate/dotnet-azure-ad-identitymodel-extensions-monorepo branch December 9, 2024 01:33
@kevinchalet kevinchalet self-assigned this Dec 9, 2024
@kevinchalet kevinchalet added the dependencies Pull requests that update a dependency file label Dec 9, 2024
@Piedone
Copy link
Member

Piedone commented Dec 9, 2024

Thank you! Grouping is possible and I've also set up a couple of these. OpenIddict packages are all in one group too. I've now put Microsoft.IdentityModel.Protocols.OpenIdConnect and Microsoft.Identity.Web into a group too, please check: #17187

Did you remove the comment here deliberately? If not, I'll re-add it there.

@kevinchalet
Copy link
Member

Did you remove the comment here deliberately? If not, I'll re-add it there.

Yeah, it was on purpose: #17018 (comment)

(and since updates are now automated, there's no point having a comment that the bot will never honor anyway 😄)

@Piedone
Copy link
Member

Piedone commented Dec 9, 2024

OK then :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants