Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReCaptchaMode and DetectionThreshold #17229

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Dec 12, 2024

Fix #17200

@MikeAlhayek
Copy link
Member Author

@rjpowers10 I have to update docs and release notes. But, can you please test this out?

The expected behavior is that if the reCapcha feature is enabled, then will always present the challenge. We no longer have threshold.

If the user tried multiple times their account will get locked after 5 tries by default during login.

I think if we ever use v3 of Google, then the challenge is handled differently but either way we won't need to worry about doing threshold ourselves.

@MikeAlhayek
Copy link
Member Author

@rjpowers10 were you able to test this out?

@rjpowers10
Copy link
Contributor

@MikeAlhayek I took a quick look and the ReCaptcha displayed in all four locations as expected.

  1. Login page
  2. Registration page
  3. Forgot password page
  4. Reset password page

@MikeAlhayek
Copy link
Member Author

Thanks for confirming.

@MikeAlhayek MikeAlhayek merged commit 00b8b5a into main Dec 17, 2024
8 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/rechapcha-remove-mode branch December 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReCaptchaSettings.DetectionThreshold is not counted correctly for log in
2 participants