Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Serilog.AspNetCore to v9 - renamed #17241

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 13, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
Serilog.AspNetCore 8.0.3 -> 9.0.0 age adoption passing confidence

Release Notes

serilog/serilog-aspnetcore (Serilog.AspNetCore)

v9.0.0

What's Changed

  • #​388 - update to .NET 9 SDK, Serilog.Extensions.Hosting/Serilog.Settings.Configuration 9.0.0, Serilog 4.2.0 (@​nblumhardt)

Configuration

📅 Schedule: Branch creation - "before 5am on Sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 13, 2024
@Piedone
Copy link
Member

Piedone commented Dec 13, 2024

Hmm, actually, the v9 package is targeting both .NET 8 and .NET 9 (and others, like .NET Standard 2.0). So, there shouldn't be a reason to keep 8.x for .NET 8, right @sebastienros? The different version I added under #17190 is not actually useful.

@Piedone
Copy link
Member

Piedone commented Dec 13, 2024

Ah no, it is necessary, because of System.Text.Json, see the build error. Rejecting this, then.

@Piedone Piedone closed this Dec 13, 2024
Copy link
Contributor Author

renovate bot commented Dec 13, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 9.x releases. But if you manually upgrade to 9.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/serilog.aspnetcore-9.x branch December 13, 2024 23:18
@sebastienros
Copy link
Member

Because the 9.0.0 version's net8.0 dependencies are pointing to net9.0 Ms packages, we need to keep pointing to 8.0.x version for the net8.0 TFM in OC.

@Piedone
Copy link
Member

Piedone commented Dec 14, 2024

Yep, thanks.

@Piedone Piedone changed the title Update dependency Serilog.AspNetCore to v9 Update dependency Serilog.AspNetCore to v9 - renamed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants